Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 19540004: Avoid lineTo() duplication in SkPath::dump(). (Closed)

Created:
7 years, 5 months ago by f(malita)
Modified:
7 years, 5 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Avoid lineTo() duplication in SkPath::dump(). Currently, SkPath.dump() produces duplicate entries for lineTo(): path.moveTo(0, 0); path.lineTo(1.00000012f, 0); path.lineTo(1.00000012f, 0); path.lineTo(1.00000012f, 1.00000012f); path.lineTo(1.00000012f, 1.00000012f); path.lineTo(0, 1.00000012f); path.lineTo(0, 1.00000012f); path.lineTo(0, 0); path.lineTo(0, 0); path.close(); R=bungeman@google.com Committed: http://code.google.com/p/skia/source/detail?r=10131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/core/SkPath.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
f(malita)
7 years, 5 months ago (2013-07-17 20:58:39 UTC) #1
bungeman-skia
I'm sure someone is depending on it, but lgtm :-)
7 years, 5 months ago (2013-07-17 21:24:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/19540004/1
7 years, 5 months ago (2013-07-17 21:24:45 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 21:39:55 UTC) #4
Message was sent while issue was closed.
Change committed as 10131

Powered by Google App Engine
This is Rietveld 408576698