runtime/vm/symbols.cc - Issue 1953803003: Fix precompile build issue with IsString change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/symbols.cc

Issue 1953803003: Fix precompile build issue with IsString change. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: self-review-comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/symbols.cc

diff --git a/runtime/vm/symbols.cc b/runtime/vm/symbols.cc

index a138437c23d4e3739df28e0f96bb4b2f530df4e5..03aa24174caa185b397155d73f4670e57133c092 100644

--- a/runtime/vm/symbols.cc

+++ b/runtime/vm/symbols.cc

@@ -405,7 +405,7 @@ intptr_t Symbols::Compact(Isolate* isolate) {

zone_(thread->zone()) {}

void VisitObject(RawObject* obj) {

- if (obj->IsString() && obj->IsCanonical()) {

+ if (obj->IsCanonical() && obj->IsStringInstance()) {

symbols_->Add(&String::ZoneHandle(zone_, String::RawCast(obj)));

}

« runtime/vm/raw_object.h ('K') | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »