Disable close-on-deactivate during tests so suprious UI events don't cause flakes

Disable close-on-deactivate during tests so suprious UI events don't cause flakes

BUG=263244
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213777

[noms, 2013-07-23 20:24:39]

lgtm

[fdoray, 2013-07-23 20:34:06]

lgtm !

[bcwhite, 2013-07-24 15:35:19]

+ben for OWNER approval, please

[Ben Goodger (Google), 2013-07-24 19:25:36]

lgtm

https://codereview.chromium.org/19537006/diff/1/chrome/browser/ui/views/avata...
File chrome/browser/ui/views/avatar_menu_bubble_view.h (right):

https://codereview.chromium.org/19537006/diff/1/chrome/browser/ui/views/avata...
chrome/browser/ui/views/avatar_menu_bubble_view.h:85: static void
CloseOnDeactivate(bool close) {
set_close_on_deactivate

[bcwhite, 2013-07-24 20:39:54]

https://codereview.chromium.org/19537006/diff/1/chrome/browser/ui/views/avata...
> chrome/browser/ui/views/avatar_menu_bubble_view.h:85: static void
> CloseOnDeactivate(bool close) {
> set_close_on_deactivate

Is there some style for naming methods that I don't understand?  Some methods
are camel-case and others are underscore-separated.  I was trying to be
consistent within this class -- there are no other underscore-separate methods
in this class.  How do you choose which style to use?

-- Brian

[bcwhite, 2013-07-24 21:05:20]

renamed method to set_close_on_deactivate

[commit-bot: I haz the power, 2013-07-25 16:28:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/19537006/13001

[Ben Goodger (Google), 2013-07-25 16:43:53]

If you're method is just setting a var my understanding was that you use
unix_hacker style

[noms, 2013-07-25 19:22:41]

https://codereview.chromium.org/19537006/diff/13001/chrome/browser/ui/views/p...
File chrome/browser/ui/views/profile_chooser_view.h (right):

https://codereview.chromium.org/19537006/diff/13001/chrome/browser/ui/views/p...
chrome/browser/ui/views/profile_chooser_view.h:49: static void
set_close_on_deactiavte(bool close) {
Blurg. Typo! :(

[commit-bot: I haz the power, 2013-07-25 23:44:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/19537006/13001

[commit-bot: I haz the power, 2013-07-26 06:38:43]

Change committed as 213777