Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 19531006: requestAutocomplete: fix some text colors (Closed)

Created:
7 years, 5 months ago by Evan Stade
Modified:
7 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tim+watch_chromium.org, Raman Kakilate, benquan, tfarina, ahutter, haitaol+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, rsimha+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

requestAutocomplete: fix some text colors most notably, make the legal documents text readable. BUG=260355 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212477

Patch Set 1 #

Total comments: 2

Patch Set 2 : +PreferredSizeChanged override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -19 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ui/views/controls/styled_label.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M ui/views/controls/styled_label.cc View 1 6 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
7 years, 5 months ago (2013-07-18 00:21:02 UTC) #1
sky
https://codereview.chromium.org/19531006/diff/1/ui/views/controls/styled_label.cc File ui/views/controls/styled_label.cc (right): https://codereview.chromium.org/19531006/diff/1/ui/views/controls/styled_label.cc#newcode115 ui/views/controls/styled_label.cc:115: calculated_size_ = gfx::Size(); Can you move calculatedSize_ = gfx::Size() ...
7 years, 5 months ago (2013-07-18 14:10:25 UTC) #2
Evan Stade
https://codereview.chromium.org/19531006/diff/1/ui/views/controls/styled_label.cc File ui/views/controls/styled_label.cc (right): https://codereview.chromium.org/19531006/diff/1/ui/views/controls/styled_label.cc#newcode115 ui/views/controls/styled_label.cc:115: calculated_size_ = gfx::Size(); On 2013/07/18 14:10:26, sky wrote: > ...
7 years, 5 months ago (2013-07-18 18:10:19 UTC) #3
sky
LGTM
7 years, 5 months ago (2013-07-18 20:02:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/19531006/21001
7 years, 5 months ago (2013-07-18 20:57:33 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 23:59:08 UTC) #6
Message was sent while issue was closed.
Change committed as 212477

Powered by Google App Engine
This is Rietveld 408576698