components/autofill/core/browser/autofill_metrics_unittest.cc - Issue 19528007: [Autofill] Temporarily drop support for street-address autocomplete type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 19528007: [Autofill] Temporarily drop support for street-address autocomplete type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update tests that used the street-address autocomplete type Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/form_structure.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_metrics_unittest.cc

diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc

index c099ebe0cb723de72e9f5f407cef31095d17047c..fbfb7b0da4f4731d8c0167c681c9f85cdddd5285 100644

--- a/components/autofill/core/browser/autofill_metrics_unittest.cc

+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc

@@ -810,7 +810,7 @@ TEST_F(AutofillMetricsTest, DeveloperEngagement) {

field.autocomplete_attribute = "email";

forms.back().fields.push_back(field);

test::CreateTestFormField("", "", "", "text", &field);

- field.autocomplete_attribute = "street-address";

+ field.autocomplete_attribute = "address-line1";

forms.back().fields.push_back(field);

// Expect both the "form parsed" metric and the author-specified field type