Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 19528005: Fix wrong bailout id in polymorphic stores. (Closed)

Created:
7 years, 5 months ago by Toon Verwaest
Modified:
7 years, 5 months ago
Reviewers:
titzer, ulan
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use id instead of assignment id, which simplifies the code a lot. #

Patch Set 3 : Count how often the setter was called #

Patch Set 4 : Add a test for deoptimizing before incrementing in polymorphic case. #

Patch Set 5 : Add test for precrement #

Total comments: 2

Patch Set 6 : Adding getter test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -32 lines) Patch
M src/hydrogen.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 9 chunks +16 lines, -29 lines 0 comments Download
A test/mjsunit/regress/poly_count_operation.js View 1 2 3 4 5 1 chunk +155 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
7 years, 5 months ago (2013-07-18 18:17:02 UTC) #1
titzer
lgtm https://chromiumcodereview.appspot.com/19528005/diff/7002/test/mjsunit/regress/poly_count_operation.js File test/mjsunit/regress/poly_count_operation.js (right): https://chromiumcodereview.appspot.com/19528005/diff/7002/test/mjsunit/regress/poly_count_operation.js#newcode45 test/mjsunit/regress/poly_count_operation.js:45: set:function(new_v) { Do we need a version of ...
7 years, 5 months ago (2013-07-19 07:23:05 UTC) #2
ulan
LGTM
7 years, 5 months ago (2013-07-19 08:34:09 UTC) #3
Toon Verwaest
https://chromiumcodereview.appspot.com/19528005/diff/7002/test/mjsunit/regress/poly_count_operation.js File test/mjsunit/regress/poly_count_operation.js (right): https://chromiumcodereview.appspot.com/19528005/diff/7002/test/mjsunit/regress/poly_count_operation.js#newcode45 test/mjsunit/regress/poly_count_operation.js:45: set:function(new_v) { Although a bit convoluted perhaps, that's exactly ...
7 years, 5 months ago (2013-07-19 08:44:16 UTC) #4
Toon Verwaest
7 years, 5 months ago (2013-07-19 08:45:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 manually as r15763 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698