Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 19525002: Pause SVG animations when the document is detached. (Closed)

Created:
7 years, 5 months ago by pdr.
Modified:
7 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, darktears, abarth-chromium, dstockwell
Visibility:
Public.

Description

Pause SVG animations when the document is detached. This patch pauses SVG animations if the document is detached or disposed (matching m_scriptedAnimationController's behavior). SVG animations will already reset when the document is re-attached so there are no additional unpause() calls. This patch allows us add an assert for document()->frame() in StyleResolver::styleForElement. No new tests as this functionality is covered with existing tests and the new assert. BUG=260966 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154382

Patch Set 1 #

Patch Set 2 : Remove defaultStyleForElement branch as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M Source/core/css/resolver/StyleResolver.cpp View 1 2 chunks +2 lines, -10 lines 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pdr.
7 years, 5 months ago (2013-07-17 05:54:34 UTC) #1
eseidel
lgtm. There branch in defaultStyleForElement which only exists to support this behavior as well. If ...
7 years, 5 months ago (2013-07-17 05:56:36 UTC) #2
eseidel
I wonder if there are pathways involving less custom code which svg animations could sign ...
7 years, 5 months ago (2013-07-17 05:57:46 UTC) #3
pdr.
On 2013/07/17 05:56:36, eseidel wrote: > lgtm. > > There branch in defaultStyleForElement which only ...
7 years, 5 months ago (2013-07-17 06:00:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/19525002/8001
7 years, 5 months ago (2013-07-17 07:06:05 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 08:53:26 UTC) #6
Message was sent while issue was closed.
Change committed as 154382

Powered by Google App Engine
This is Rietveld 408576698