Issue 19520011: Remove the last SVG callers of bloatedCharacters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19520011: Remove the last SVG callers of bloatedCharacters (Closed)

Created:
7 years, 5 months ago by abarth-chromium

Modified:
7 years, 5 months ago

Reviewers:
eseidel

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove the last SVG callers of bloatedCharacters This CL removes the calls to bloatedCharacters from SVGTextLayoutEngine and SVGTextLayoutAttributesBuilder. Originally, these call sites looked scary to me, but they turned out to be fairly straightforward. R=eseidel BUG=254708 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154539

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -16 lines)			Patch
M	Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.cpp	View	4 chunks	+6 lines, -7 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutEngine.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutEngineSpacing.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/svg/SVGTextLayoutEngineSpacing.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/19520011/1

7 years, 5 months ago (2013-07-18 19:53:19 UTC) #3

Message was sent while issue was closed.

Change committed as 154539

Expand Messages | Collapse Messages