|
Change google_api::RequestSender to take an AuthService instead of a Profile.
This way, we can plug-in a dummy instance of AuthService in tests, and then
* We can remove TestingProfile completely from c/b/google_apis/.
* Several for_testing() methods can be removed.
* Switching the internals of AuthService to OAuth2TokenService (162157)
gets more smooth, since tests for request classes are
completely separated from AuthService.
BUG= 162157
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212079
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+142 lines, -144 lines) |
Patch |
|
M |
chrome/browser/chromeos/contacts/gdata_contacts_service.h
|
View
|
|
4 chunks |
+2 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/contacts/gdata_contacts_service.cc
|
View
|
|
3 chunks |
+2 lines, -17 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/contacts/gdata_contacts_service_stub.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/contacts/gdata_contacts_service_stub.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc
|
View
|
|
4 chunks |
+2 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/contacts/google_contact_store.cc
|
View
|
|
2 chunks |
+9 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/drive/drive_api_service.cc
|
View
|
|
1 chunk |
+6 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/drive/gdata_wapi_service.h
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/drive/gdata_wapi_service.cc
|
View
|
|
2 chunks |
+5 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/google_apis/DEPS
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/google_apis/auth_service.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/google_apis/auth_service.cc
|
View
|
|
2 chunks |
+10 lines, -17 lines |
0 comments
|
Download
|
|
M |
chrome/browser/google_apis/auth_service_interface.h
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/google_apis/base_requests_server_unittest.cc
|
View
|
|
4 chunks |
+10 lines, -13 lines |
0 comments
|
Download
|
|
M |
chrome/browser/google_apis/base_requests_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/google_apis/drive_api_requests_unittest.cc
|
View
|
|
4 chunks |
+2 lines, -10 lines |
0 comments
|
Download
|
|
A |
chrome/browser/google_apis/dummy_auth_service.h
|
View
|
|
1 chunk |
+35 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/google_apis/dummy_auth_service.cc
|
View
|
|
1 chunk |
+39 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/google_apis/gdata_wapi_requests_unittest.cc
|
View
|
|
4 chunks |
+2 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/google_apis/request_sender.h
|
View
|
|
4 chunks |
+8 lines, -10 lines |
0 comments
|
Download
|
|
M |
chrome/browser/google_apis/request_sender.cc
|
View
|
|
2 chunks |
+2 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests_unit.gypi
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
Total messages: 6 (0 generated)
|