Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLTextFormControlElement.h ('k') | Source/core/html/HiddenInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLTextFormControlElement.cpp
diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp
index cae2d7932eeb208808342910c0f12a7d2632e33a..f4c2e4bbf94b928bd4d244c13f2c68a2b907e5e8 100644
--- a/Source/core/html/HTMLTextFormControlElement.cpp
+++ b/Source/core/html/HTMLTextFormControlElement.cpp
@@ -640,7 +640,7 @@ String HTMLTextFormControlElement::valueWithHardLineBreaks() const
return finishText(result);
}
-HTMLTextFormControlElement* enclosingTextFormControl(const Position& position)
+Result<HTMLTextFormControlElement> enclosingTextFormControl(const Position& position)
{
ASSERT(position.isNull() || position.anchorType() == Position::PositionIsOffsetInAnchor
|| position.containerNode() || !position.anchorNode()->shadowHost()
@@ -648,9 +648,9 @@ HTMLTextFormControlElement* enclosingTextFormControl(const Position& position)
Node* container = position.containerNode();
if (!container)
- return 0;
+ return nullptr;
Element* ancestor = container->shadowHost();
- return ancestor && isHTMLTextFormControlElement(ancestor) ? toHTMLTextFormControlElement(ancestor) : 0;
+ return ancestor && isHTMLTextFormControlElement(ancestor) ? toHTMLTextFormControlElement(ancestor) : nullptr;
}
static const Element* parentHTMLElement(const Element* element)
@@ -690,4 +690,9 @@ void HTMLTextFormControlElement::reportMemoryUsage(MemoryObjectInfo* memoryObjec
info.addMember(m_textAsOfLastFormControlChangeEvent, "textAsOfLastFormControlChangeEvent");
}
+void HTMLTextFormControlElement::acceptHeapVisitor(Visitor* visitor) const
+{
+ HTMLFormControlElementWithState::acceptHeapVisitor(visitor);
+}
+
} // namespace Webcore
« no previous file with comments | « Source/core/html/HTMLTextFormControlElement.h ('k') | Source/core/html/HiddenInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698