Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: Source/core/html/HTMLOptGroupElement.cpp

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLOptGroupElement.h ('k') | Source/core/html/HTMLOptionElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLOptGroupElement.cpp
diff --git a/Source/core/html/HTMLOptGroupElement.cpp b/Source/core/html/HTMLOptGroupElement.cpp
index f7da9576654735de5225a906a37dec29578b3f2e..c2b8e86a4b006ba60bc9aa24aa38df3fea2c8c59 100644
--- a/Source/core/html/HTMLOptGroupElement.cpp
+++ b/Source/core/html/HTMLOptGroupElement.cpp
@@ -143,21 +143,21 @@ String HTMLOptGroupElement::groupLabelText() const
return itemText;
}
-HTMLSelectElement* HTMLOptGroupElement::ownerSelectElement() const
+Result<HTMLSelectElement> HTMLOptGroupElement::ownerSelectElement() const
{
ContainerNode* select = parentNode();
while (select && !select->hasTagName(selectTag))
select = select->parentNode();
if (!select)
- return 0;
+ return nullptr;
return toHTMLSelectElement(select);
}
void HTMLOptGroupElement::accessKeyAction(bool)
{
- HTMLSelectElement* select = ownerSelectElement();
+ Handle<HTMLSelectElement> select = ownerSelectElement();
// send to the parent to bring focus to the list box
if (select && !select->focused())
select->accessKeyAction(false);
« no previous file with comments | « Source/core/html/HTMLOptGroupElement.h ('k') | Source/core/html/HTMLOptionElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698