Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/editing/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index a67df3694d563d68a2790993257045d507a096ab..ca29e1eb132312f4f17a9b264b72d346d18ee5ac 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -1598,7 +1598,7 @@ void FrameSelection::selectAll()
Document* document = m_frame->document();
if (document->focusedNode() && document->focusedNode()->hasTagName(selectTag)) {
- HTMLSelectElement* selectElement = toHTMLSelectElement(document->focusedNode());
+ Handle<HTMLSelectElement> selectElement = toHTMLSelectElement(document->focusedNode());
if (selectElement->canSelectAll()) {
selectElement->selectAll();
return;
@@ -1661,8 +1661,8 @@ bool FrameSelection::setSelectedRange(Range* range, EAffinity affinity, bool clo
bool FrameSelection::isInPasswordField() const
{
- HTMLTextFormControlElement* textControl = enclosingTextFormControl(start());
- return textControl && textControl->hasTagName(inputTag) && static_cast<HTMLInputElement*>(textControl)->isPasswordField();
+ Handle<HTMLTextFormControlElement> textControl = enclosingTextFormControl(start());
+ return textControl && textControl->hasTagName(inputTag) && Handle<HTMLInputElement>::cast(textControl)->isPasswordField();
}
void FrameSelection::focusedOrActiveStateChanged()
@@ -1825,7 +1825,7 @@ void FrameSelection::notifyRendererOfSelectionChange(EUserTriggered userTriggere
{
m_frame->document()->updateStyleIfNeeded();
- if (HTMLTextFormControlElement* textControl = enclosingTextFormControl(start()))
+ if (Handle<HTMLTextFormControlElement> textControl = enclosingTextFormControl(start()))
textControl->selectionChanged(userTriggered == UserTriggered);
}
« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/editing/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698