Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/CodeGeneratorV8.pm ('k') | Source/core/accessibility/AXObjectCache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp
diff --git a/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp b/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp
index ee1aedb99a7ff28acc93cdb7d4b9410e9a25bc48..72e6aadfc0a255ecd06ff8fba68e3a3c05d1b12e 100644
--- a/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp
+++ b/Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp
@@ -86,8 +86,8 @@ v8::Handle<v8::Value> V8HTMLOptionsCollection::namedItemMethodCustom(const v8::A
v8::Handle<v8::Value> V8HTMLOptionsCollection::removeMethodCustom(const v8::Arguments& args)
{
HTMLOptionsCollection* imp = V8HTMLOptionsCollection::toNative(args.Holder());
- HTMLSelectElement* base = toHTMLSelectElement(imp->ownerNode());
- return removeElement(base, args);
+ Handle<HTMLSelectElement> base = toHTMLSelectElement(imp->ownerNode());
+ return removeElement(base.raw(), args);
}
v8::Handle<v8::Value> V8HTMLOptionsCollection::addMethodCustom(const v8::Arguments& args)
@@ -151,8 +151,8 @@ v8::Handle<v8::Value> V8HTMLOptionsCollection::indexedPropertySetter(uint32_t in
{
HandleScope handleScope;
HTMLOptionsCollection* collection = V8HTMLOptionsCollection::toNative(info.Holder());
- HTMLSelectElement* base = toHTMLSelectElement(collection->ownerNode());
- return toOptionsCollectionSetter(index, value, base, info.GetIsolate());
+ Handle<HTMLSelectElement> base = toHTMLSelectElement(collection->ownerNode());
+ return toOptionsCollectionSetter(index, value, base.raw(), info.GetIsolate());
}
} // namespace WebCore
« no previous file with comments | « Source/bindings/scripts/CodeGeneratorV8.pm ('k') | Source/core/accessibility/AXObjectCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698