Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Unified Diff: Source/core/loader/FormSubmission.cpp

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/page/Chrome.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FormSubmission.cpp
diff --git a/Source/core/loader/FormSubmission.cpp b/Source/core/loader/FormSubmission.cpp
index e3ba77e6f3d93cbb161fe7673e7c7de5ea148a2c..b781474ffb7a243915116fbce4df4cd505933e6a 100644
--- a/Source/core/loader/FormSubmission.cpp
+++ b/Source/core/loader/FormSubmission.cpp
@@ -141,11 +141,11 @@ PassRefPtr<FormSubmission> FormSubmission::create(HTMLFormElement* form, const A
{
ASSERT(form);
- HTMLFormControlElement* submitButton = 0;
+ Handle<HTMLFormControlElement> submitButton;
if (event && event->target()) {
for (Node* node = event->target()->toNode(); node; node = node->parentNode()) {
if (node->isElementNode() && toElement(node)->isFormControlElement()) {
- submitButton = static_cast<HTMLFormControlElement*>(node);
+ submitButton = Handle<HTMLFormControlElement>(static_cast<HTMLFormControlElement*>(node));
break;
}
}
@@ -190,7 +190,7 @@ PassRefPtr<FormSubmission> FormSubmission::create(HTMLFormElement* form, const A
if (!element->isDisabledFormControl())
control->appendFormData(*domFormData, isMultiPartForm);
if (element->hasLocalName(inputTag)) {
- HTMLInputElement* input = static_cast<HTMLInputElement*>(control);
+ Handle<HTMLInputElement> input(static_cast<HTMLInputElement*>(control));
if (input->isTextField()) {
formValues.append(pair<String, String>(input->name().string(), input->value()));
input->addSearchResult();
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/page/Chrome.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698