Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: Source/WebKit/chromium/src/WebPasswordFormData.cpp

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebKit/chromium/src/WebInputElement.cpp ('k') | Source/WebKit/chromium/src/WebPasswordFormUtils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/src/WebPasswordFormData.cpp
diff --git a/Source/WebKit/chromium/src/WebPasswordFormData.cpp b/Source/WebKit/chromium/src/WebPasswordFormData.cpp
index fe846e99c2c6fd00a36d2004671b78e14b7fe858..2b35c5724c5cc24b7deaba9f3a074fa9580363e9 100644
--- a/Source/WebKit/chromium/src/WebPasswordFormData.cpp
+++ b/Source/WebKit/chromium/src/WebPasswordFormData.cpp
@@ -111,11 +111,11 @@ KURL stripURL(const KURL& url)
// Helper to gather up the final form data and create a PasswordForm.
void assemblePasswordFormResult(const KURL& fullOrigin,
const KURL& fullAction,
- HTMLFormControlElement* submit,
- HTMLInputElement* userName,
+ Handle<HTMLFormControlElement> submit,
+ Handle<HTMLInputElement> userName,
const Vector<String>& alternateUserNames,
- HTMLInputElement* oldPassword,
- HTMLInputElement* password,
+ Handle<HTMLInputElement> oldPassword,
+ Handle<HTMLInputElement> password,
WebPasswordFormData* result)
{
// We want to keep the path but strip any authentication data, as well as
@@ -173,10 +173,14 @@ WebPasswordFormData::WebPasswordFormData(const WebFormElement& webForm)
if (!locateSpecificPasswords(&fields, &password, &oldPassword))
return;
+ // FIXME(oilpan): Remove Handle<>().
assemblePasswordFormResult(fullOrigin, fullAction,
- fields.submit, fields.userName,
- fields.alternateUserNames,
- oldPassword, password, this);
+ Handle<HTMLFormControlElement>(fields.submit),
+ Handle<HTMLInputElement>(fields.userName),
+ fields.alternateUserNames,
+ Handle<HTMLInputElement>(oldPassword),
+ Handle<HTMLInputElement>(password),
+ this);
}
} // namespace WebKit
« no previous file with comments | « Source/WebKit/chromium/src/WebInputElement.cpp ('k') | Source/WebKit/chromium/src/WebPasswordFormUtils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698