Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: Source/WebKit/chromium/src/WebFormElement.cpp

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/WebFormElement.cpp
diff --git a/Source/WebKit/chromium/src/WebFormElement.cpp b/Source/WebKit/chromium/src/WebFormElement.cpp
index 85341ba50bccb56823e67f8c309c2f49458d1689..1398ed8d40dfc2a2a18a6a597e45d629540b714f 100644
--- a/Source/WebKit/chromium/src/WebFormElement.cpp
+++ b/Source/WebKit/chromium/src/WebFormElement.cpp
@@ -87,19 +87,19 @@ void WebFormElement::getNamedElements(const WebString& name,
void WebFormElement::getFormControlElements(WebVector<WebFormControlElement>& result) const
{
const HTMLFormElement* form = constUnwrap<HTMLFormElement>();
- Vector<RefPtr<HTMLFormControlElement> > tempVector;
+ CollectionRoot<Vector<Member<HTMLFormControlElement> > > tempVector;
// FIXME: We should move the for-loop condition into a variable instead of
// re-evaluating size each time. Also, consider refactoring this code so that
// we don't call form->associatedElements() multiple times.
for (size_t i = 0; i < form->associatedElements().size(); i++) {
if (!form->associatedElements()[i]->isFormControlElement())
continue;
- HTMLFormControlElement* element = static_cast<HTMLFormControlElement*>(form->associatedElements()[i]);
+ Handle<HTMLFormControlElement> element(static_cast<HTMLFormControlElement*>(form->associatedElements()[i]));
if (element->hasLocalName(HTMLNames::inputTag)
|| element->hasLocalName(HTMLNames::selectTag))
- tempVector.append(element);
+ tempVector->append(element);
}
- result.assign(tempVector);
+ result.assign(*tempVector);
}
void WebFormElement::finishRequestAutocomplete(WebFormElement::AutocompleteResult result)
« no previous file with comments | « Source/WebKit/chromium/src/WebFormControlElement.cpp ('k') | Source/WebKit/chromium/src/WebInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698