Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: Source/core/html/RangeInputType.cpp

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/RangeInputType.h ('k') | Source/core/html/ResetInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/RangeInputType.cpp
diff --git a/Source/core/html/RangeInputType.cpp b/Source/core/html/RangeInputType.cpp
index 75ebd800e32e7491758dea27d221b053ffc00433..7f6a366af3912b25aaca661478efd9add62dfcd6 100644
--- a/Source/core/html/RangeInputType.cpp
+++ b/Source/core/html/RangeInputType.cpp
@@ -77,12 +77,12 @@ static Decimal ensureMaximum(const Decimal& proposedValue, const Decimal& minimu
return proposedValue >= minimum ? proposedValue : std::max(minimum, fallbackValue);
}
-PassOwnPtr<InputType> RangeInputType::create(HTMLInputElement* element)
+PassOwnPtr<InputType> RangeInputType::create(Handle<HTMLInputElement> element)
{
return adoptPtr(new RangeInputType(element));
}
-RangeInputType::RangeInputType(HTMLInputElement* element)
+RangeInputType::RangeInputType(Handle<HTMLInputElement> element)
: InputType(element)
#if ENABLE(DATALIST_ELEMENT)
, m_tickMarkValuesDirty(true)
@@ -158,7 +158,7 @@ void RangeInputType::handleMouseDownEvent(MouseEvent* event)
ASSERT(element()->shadow());
if (targetNode != element() && !targetNode->isDescendantOf(element()->userAgentShadowRoot()))
return;
- SliderThumbElement* thumb = sliderThumbElementOf(element());
+ SliderThumbElement* thumb = sliderThumbElementOf(Handle<HTMLInputElement>(element()).raw());
if (targetNode == thumb)
return;
thumb->dragFrom(event->absoluteLocation());
@@ -177,7 +177,7 @@ void RangeInputType::handleTouchEvent(TouchEvent* event)
TouchList* touches = event->targetTouches();
if (touches->length() == 1) {
Touch* touch = touches->item(0);
- SliderThumbElement* thumb = sliderThumbElementOf(element());
+ SliderThumbElement* thumb = sliderThumbElementOf(Handle<HTMLInputElement>(element()).raw());
thumb->setPositionFromPoint(touch->absoluteLocation());
event->setDefaultHandled();
}
@@ -240,7 +240,7 @@ void RangeInputType::handleKeydownEvent(KeyboardEvent* event)
setValueAsDecimal(newValue, eventBehavior, IGNORE_EXCEPTION);
if (AXObjectCache* cache = element()->document()->existingAXObjectCache())
- cache->postNotification(element(), AXObjectCache::AXValueChanged, true);
+ cache->postNotification(Handle<HTMLInputElement>(element()).raw(), AXObjectCache::AXValueChanged, true);
element()->dispatchFormControlChangeEvent();
}
@@ -302,7 +302,7 @@ void RangeInputType::setValue(const String& value, bool valueChanged, TextFieldE
if (!valueChanged)
return;
- sliderThumbElementOf(element())->setPositionFromValue();
+ sliderThumbElementOf(Handle<HTMLInputElement>(element()).raw())->setPositionFromValue();
}
String RangeInputType::fallbackValue() const
@@ -324,19 +324,19 @@ bool RangeInputType::shouldRespectListAttribute()
HTMLElement* RangeInputType::sliderThumbElement() const
{
- return sliderThumbElementOf(element());
+ return sliderThumbElementOf(Handle<HTMLInputElement>(element()).raw());
}
HTMLElement* RangeInputType::sliderTrackElement() const
{
- return sliderTrackElementOf(element());
+ return sliderTrackElementOf(Handle<HTMLInputElement>(element()).raw());
}
#if ENABLE(DATALIST_ELEMENT)
void RangeInputType::listAttributeTargetChanged()
{
m_tickMarkValuesDirty = true;
- HTMLElement* sliderTrackElement = sliderTrackElementOf(element());
+ HTMLElement* sliderTrackElement = sliderTrackElementOf(Handle<HTMLInputElement>(element()).raw());
if (sliderTrackElement->renderer())
sliderTrackElement->renderer()->setNeedsLayout(true);
}
« no previous file with comments | « Source/core/html/RangeInputType.h ('k') | Source/core/html/ResetInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698