Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: Source/core/page/Chrome.cpp

Issue 19510005: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/FormSubmission.cpp ('k') | Source/core/page/ChromeClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2009, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * Copyright (C) 2012, Samsung Electronics. All rights reserved. 4 * Copyright (C) 2012, Samsung Electronics. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 String toolTip = result.spellingToolTip(toolTipDirection); 391 String toolTip = result.spellingToolTip(toolTipDirection);
392 392
393 // Next we'll consider a tooltip for element with "title" attribute 393 // Next we'll consider a tooltip for element with "title" attribute
394 if (toolTip.isEmpty()) 394 if (toolTip.isEmpty())
395 toolTip = result.title(toolTipDirection); 395 toolTip = result.title(toolTipDirection);
396 396
397 // Lastly, for <input type="file"> that allow multiple files, we'll consider a tooltip for the selected filenames 397 // Lastly, for <input type="file"> that allow multiple files, we'll consider a tooltip for the selected filenames
398 if (toolTip.isEmpty()) { 398 if (toolTip.isEmpty()) {
399 if (Node* node = result.innerNonSharedNode()) { 399 if (Node* node = result.innerNonSharedNode()) {
400 if (node->hasTagName(inputTag)) { 400 if (node->hasTagName(inputTag)) {
401 HTMLInputElement* input = static_cast<HTMLInputElement*>(node); 401 Handle<HTMLInputElement> input(static_cast<HTMLInputElement*>(no de));
402 toolTip = input->defaultToolTip(); 402 toolTip = input->defaultToolTip();
403 403
404 // FIXME: We should obtain text direction of tooltip from 404 // FIXME: We should obtain text direction of tooltip from
405 // ChromeClient or platform. As of October 2011, all client 405 // ChromeClient or platform. As of October 2011, all client
406 // implementations don't use text direction information for 406 // implementations don't use text direction information for
407 // ChromeClient::setToolTip. We'll work on tooltip text 407 // ChromeClient::setToolTip. We'll work on tooltip text
408 // direction during bidi cleanup in form inputs. 408 // direction during bidi cleanup in form inputs.
409 toolTipDirection = LTR; 409 toolTipDirection = LTR;
410 } 410 }
411 } 411 }
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
551 } 551 }
552 552
553 void Chrome::notifyPopupOpeningObservers() const 553 void Chrome::notifyPopupOpeningObservers() const
554 { 554 {
555 const Vector<PopupOpeningObserver*> observers(m_popupOpeningObservers); 555 const Vector<PopupOpeningObserver*> observers(m_popupOpeningObservers);
556 for (size_t i = 0; i < observers.size(); ++i) 556 for (size_t i = 0; i < observers.size(); ++i)
557 observers[i]->willOpenPopup(); 557 observers[i]->willOpenPopup();
558 } 558 }
559 559
560 } // namespace WebCore 560 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/loader/FormSubmission.cpp ('k') | Source/core/page/ChromeClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698