Issue 19509007: [Android WebView] Fix cancelling FallbackTick

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19509007: [Android WebView] Fix cancelling FallbackTick (Closed)

Created:
7 years, 5 months ago by boliu

Modified:
7 years, 5 months ago

Reviewers:
joth

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android WebView] Fix cancelling FallbackTick Inside OnDraw, RequestDrawGL can fail and return false, which means there will not be a follow up DrawGL call to actually trigger the draw, but the FallbackTick is cancelled anyway. Fix by moving the cancel inside DrawSWInteral to reflect we only want to cancel when we actually draw. BUG=internal b/9978808 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213302

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	android_webview/browser/in_process_view_renderer.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/19509007/1

7 years, 5 months ago (2013-07-24 00:54:06 UTC) #3

Message was sent while issue was closed.

Change committed as 213302

Expand Messages | Collapse Messages