Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: Source/core/html/ValidationMessage.h

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/ValidationMessage.h
diff --git a/Source/core/html/ValidationMessage.h b/Source/core/html/ValidationMessage.h
index 83c7f268d39f85b04afa065b755ed0098d5def20..f4a5469e2a01eba2e4bd0d1b41c5535eac8645a7 100644
--- a/Source/core/html/ValidationMessage.h
+++ b/Source/core/html/ValidationMessage.h
@@ -32,6 +32,7 @@
#define ValidationMessage_h
#include "core/platform/Timer.h"
+#include "heap/Handle.h"
#include <wtf/Noncopyable.h>
#include <wtf/OwnPtr.h>
#include <wtf/RefPtr.h>
@@ -49,7 +50,7 @@ class ValidationMessageClient;
class ValidationMessage {
WTF_MAKE_NONCOPYABLE(ValidationMessage); WTF_MAKE_FAST_ALLOCATED;
public:
- static PassOwnPtr<ValidationMessage> create(HTMLFormControlElement*);
+ static PassOwnPtr<ValidationMessage> create(Handle<HTMLFormControlElement>);
~ValidationMessage();
void updateValidationMessage(const String&);
void requestToHideMessage();
@@ -57,13 +58,14 @@ public:
bool shadowTreeContains(Node*) const;
private:
- ValidationMessage(HTMLFormControlElement*);
+ ValidationMessage(Handle<HTMLFormControlElement>);
ValidationMessageClient* validationMessageClient() const;
void setMessage(const String&);
void setMessageDOMAndStartTimer(Timer<ValidationMessage>* = 0);
void buildBubbleTree(Timer<ValidationMessage>*);
void deleteBubbleTree(Timer<ValidationMessage>* = 0);
+ // FIXME(oilpan): Move ValidationMessage to the heap and use a Member.
HTMLFormControlElement* m_element;
String m_message;
OwnPtr<Timer<ValidationMessage> > m_timer;

Powered by Google App Engine
This is Rietveld 408576698