Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: Source/core/accessibility/AccessibilitySlider.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/accessibility/AccessibilitySlider.cpp
diff --git a/Source/core/accessibility/AccessibilitySlider.cpp b/Source/core/accessibility/AccessibilitySlider.cpp
index f29104df6fb16f62a81aea0875504907369aaee2..c70cce0e05bef083eba0b2b1975582a2945795f1 100644
--- a/Source/core/accessibility/AccessibilitySlider.cpp
+++ b/Source/core/accessibility/AccessibilitySlider.cpp
@@ -127,7 +127,7 @@ float AccessibilitySlider::minValueForRange() const
void AccessibilitySlider::setValue(const String& value)
{
- HTMLInputElement* input = element();
+ Handle<HTMLInputElement> input = element();
if (input->value() == value)
return;
@@ -138,9 +138,9 @@ void AccessibilitySlider::setValue(const String& value)
input->dispatchFormControlChangeEvent();
}
-HTMLInputElement* AccessibilitySlider::element() const
+Result<HTMLInputElement> AccessibilitySlider::element() const
{
- return static_cast<HTMLInputElement*>(m_renderer->node());
+ return Handle<HTMLInputElement>(static_cast<HTMLInputElement*>(m_renderer->node()));
haraken 2013/07/17 14:10:23 I didn't add a FIXME for Handle<X>(static_cast<X*>
Vyacheslav Egorov (Google) 2013/07/18 16:50:08 I would use adoptRawResult instead of Handle<>() f
haraken 2013/07/19 02:57:09 Done.
}

Powered by Google App Engine
This is Rietveld 408576698