Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: Source/WebKit/chromium/src/WebInputElement.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/WebInputElement.cpp
diff --git a/Source/WebKit/chromium/src/WebInputElement.cpp b/Source/WebKit/chromium/src/WebInputElement.cpp
index 1131f943b01fa6cca0080a9bbee9c514a34560fd..eb123a4c42ec49ed2889006b0387acbb60e0c545 100644
--- a/Source/WebKit/chromium/src/WebInputElement.cpp
+++ b/Source/WebKit/chromium/src/WebInputElement.cpp
@@ -41,6 +41,7 @@
#include "core/html/HTMLInputElement.h"
#include "core/html/shadow/TextControlInnerElements.h"
#include "core/html/shadow/TextFieldDecorationElement.h"
+#include "heap/Handle.h"
#include <public/WebString.h>
#include <wtf/PassRefPtr.h>
@@ -258,25 +259,25 @@ WebElement WebInputElement::decorationElementFor(WebTextFieldDecoratorClient* de
return WebElement();
}
-WebInputElement::WebInputElement(const PassRefPtr<HTMLInputElement>& elem)
+WebInputElement::WebInputElement(Handle<HTMLInputElement> elem)
: WebFormControlElement(elem)
{
}
-WebInputElement& WebInputElement::operator=(const PassRefPtr<HTMLInputElement>& elem)
+WebInputElement& WebInputElement::operator=(Handle<HTMLInputElement> elem)
{
- m_private = elem;
+ m_private = elem.passRefPtr();
return *this;
}
-WebInputElement::operator PassRefPtr<HTMLInputElement>() const
+WebInputElement::operator Handle<HTMLInputElement>() const
Vyacheslav Egorov (Google) 2013/07/18 16:50:08 Consider instead: WebInputElement::operator Resul
haraken 2013/07/19 02:57:09 Done.
{
- return static_cast<HTMLInputElement*>(m_private.get());
+ return Handle<HTMLInputElement>(static_cast<HTMLInputElement*>(m_private.get()));
}
WebInputElement* toWebInputElement(WebElement* webElement)
{
- HTMLInputElement* inputElement = webElement->unwrap<Element>()->toInputElement();
+ Handle<HTMLInputElement> inputElement = webElement->unwrap<Element>()->toInputElement();
if (!inputElement)
return 0;

Powered by Google App Engine
This is Rietveld 408576698