Add support for Device.ProposeScan to NetworkDeviceHandler.

Add support for Device.ProposeScan to NetworkDeviceHandler.

This CL adds the D-Bus hook for calling Device.ProposeScan to
NetworkDeviceHandler as well as bindings for and a function to parse
the results of a cellular network scan which are exposed form shill
as a Device property.

BUG=260964
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213313

[gauravsh, 2013-07-19 22:59:35]

https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_devi...
File chromeos/network/network_device_handler.h (right):

https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_devi...
chromeos/network/network_device_handler.h:73: // Remove this method once shill
supports that.
Can you file a bug and reference it here as well?

https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_util.h
File chromeos/network/network_util.h (right):

https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_util...
chromeos/network/network_util.h:48: // Strict for passing network scan result
data.
Struct

https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_util...
chromeos/network/network_util.h:50: CellularScanResult();
Since all members are class types, it doesn't look like you really need a
constructor/destructor, do you?

[gauravsh, 2013-07-19 23:00:01]

and oh LGTM modulo these comments

On 2013/07/19 22:59:35, gauravsh wrote:
>
https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_devi...
> File chromeos/network/network_device_handler.h (right):
> 
>
https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_devi...
> chromeos/network/network_device_handler.h:73: // Remove this method once shill
> supports that.
> Can you file a bug and reference it here as well?
> 
>
https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_util.h
> File chromeos/network/network_util.h (right):
> 
>
https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_util...
> chromeos/network/network_util.h:48: // Strict for passing network scan result
> data.
> Struct
> 
>
https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_util...
> chromeos/network/network_util.h:50: CellularScanResult();
> Since all members are class types, it doesn't look like you really need a
> constructor/destructor, do you?

[armansito, 2013-07-19 23:20:02]

https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_devi...
File chromeos/network/network_device_handler.h (right):

https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_devi...
chromeos/network/network_device_handler.h:73: // Remove this method once shill
supports that.
On 2013/07/19 22:59:35, gauravsh wrote:
> Can you file a bug and reference it here as well?

Done.

https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_util.h
File chromeos/network/network_util.h (right):

https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_util...
chromeos/network/network_util.h:48: // Strict for passing network scan result
data.
On 2013/07/19 22:59:35, gauravsh wrote:
> Struct

Done.

https://codereview.chromium.org/19509002/diff/1/chromeos/network/network_util...
chromeos/network/network_util.h:50: CellularScanResult();
On 2013/07/19 22:59:35, gauravsh wrote:
> Since all members are class types, it doesn't look like you really need a
> constructor/destructor, do you?

The style guide says that you should declare a default constructor if no other
constructor exists
(https://www.corp.google.com/eng/doc/cppguide.xml?showone=Default_Constructors...).
It says this for classes but it should apply to structs as well, since they are
almost the same in C++. I added the constructor to be consistent with the other
structs defined in this file.

[commit-bot: I haz the power, 2013-07-19 23:26:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/19509002/8001

[commit-bot: I haz the power, 2013-07-22 22:49:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/19509002/8001

[commit-bot: I haz the power, 2013-07-22 22:59:35]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-07-22 23:54:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/19509002/8001

[commit-bot: I haz the power, 2013-07-23 00:52:29]

Retried try job too often on linux_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-07-24 00:57:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/armansito@chromium.org/19509002/8001

[commit-bot: I haz the power, 2013-07-24 01:33:29]

Change committed as 213313