Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 19494008: Clarify geolocation OWNERS (Closed)

Created:
7 years, 5 months ago by joth
Modified:
7 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Miguel Garcia
Visibility:
Public.

Description

Clarify geolocation OWNERS Add mvanouwerkerk as reviewer, but not yet an OWNER (as not yet a committer) NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212596

Patch Set 1 #

Patch Set 2 : reworked #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/geolocation/OWNERS View 1 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/geolocation/OWNERS View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
joth
I based the wording on //chrome/OWNERS
7 years, 5 months ago (2013-07-18 20:18:25 UTC) #1
Michael van Ouwerkerk
lgtm
7 years, 5 months ago (2013-07-18 20:33:23 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 5 months ago (2013-07-18 20:34:50 UTC) #3
joth
OK reworked as I hadn't realized you're not yet a committer Michael
7 years, 5 months ago (2013-07-18 22:10:39 UTC) #4
bulach
lgtm, sad, sad day :-/
7 years, 5 months ago (2013-07-19 09:02:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/19494008/5001
7 years, 5 months ago (2013-07-19 16:58:29 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-19 16:58:40 UTC) #7
Message was sent while issue was closed.
Change committed as 212596

Powered by Google App Engine
This is Rietveld 408576698