Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: pkg/mdv/lib/src/input_bindings.dart

Issue 19492018: [mdv] Avoid observing placeholder arrays in TemplateIterator (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/mdv/lib/mdv.dart ('k') | pkg/mdv/lib/src/list_diff.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/mdv/lib/src/input_bindings.dart
diff --git a/pkg/mdv/lib/src/input_bindings.dart b/pkg/mdv/lib/src/input_bindings.dart
index 167fd763bc00d4fa47864ac3f33b81be081aaa0b..3676691b67568f3b0f3dd376a506cee18ced6377 100644
--- a/pkg/mdv/lib/src/input_bindings.dart
+++ b/pkg/mdv/lib/src/input_bindings.dart
@@ -154,15 +154,14 @@ class _SelectedIndexBinding extends _InputBinding {
// loop to schedule on. (See the the "ensureScheduled" function:
// https://github.com/Polymer/mdv/commit/9a51ad7ed74a292bf71662cea28acbd151ff65c8)
//
- // Instead we use runAsync. Each <template repeat> needs a delay of 3:
+ // Instead we use runAsync. Each <template repeat> needs a delay of 2:
// * once to happen after the child _TemplateIterator is created
// * once to be after _TemplateIterator.inputs CompoundBinding resolve
- // * once to be after _TemplateIterator._valueBinding PathObserver fires
// And then we need to do this delay sequence twice:
// * once for OPTGROUP
// * once for OPTION.
- // The resulting 2 * 3 is our maxRetries.
- var maxRetries = 6;
+ // The resulting 2 * 2 is our maxRetries.
+ var maxRetries = 4;
delaySetSelectedIndex() {
if (newValue > element.length && --maxRetries >= 0) {
runAsync(delaySetSelectedIndex);
« no previous file with comments | « pkg/mdv/lib/mdv.dart ('k') | pkg/mdv/lib/src/list_diff.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698