[mdv] Avoid observing placeholder arrays in TemplateIterator

pkg/mdv/lib/src/template_iterator.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of mdv;
 
 // This code is a port of Model-Driven-Views:
 // https://github.com/polymer-project/mdv
 // The code mostly comes from src/template_element.js
 
@@ skipping 172 matching lines @@
   final bool isBinding;
 
   _BindingToken(this.value, {this.isBinding: false});
 
   bool get isText => !isBinding;
 }
 
 class _TemplateIterator {
   final Element _templateElement;
   final List<Node> terminators = [];
-  final CompoundBinding inputs;
+  CompoundBinding inputs;
   List iteratedValue;
-  Object _lastValue;
+  bool closed = false;
 
   StreamSubscription _sub;
-  StreamSubscription _valueBinding;
 
-  _TemplateIterator(this._templateElement)
-      : inputs = new CompoundBinding(resolveInputs) {
-
-    _valueBinding = new PathObserver(inputs, 'value').bindSync(valueChanged);
+  _TemplateIterator(this._templateElement) {
+    inputs = new CompoundBinding(resolveInputs);
   }
 
-  static Object resolveInputs(Map values) {
+  void resolveInputs(Map values) {
+    if (closed) return;
+
     if (values.containsKey('if') && !_toBoolean(values['if'])) {
-      return null;
+      valueChanged(null);
+    } else if (values.containsKey('repeat')) {
+      valueChanged(values['repeat']);
+    } else if (values.containsKey('bind') || values.containsKey('if')) {
+      valueChanged([values['bind']]);
+    } else {
+      valueChanged(null);
     }
-
-    if (values.containsKey('repeat')) {
-      return values['repeat'];
-    }
-
-    if (values.containsKey('bind') || values.containsKey('if')) {
-      return [values['bind']];
-    }
-
-    return null;
   }
 
   void valueChanged(value) {
-    // TODO(jmesserly): should PathObserver do this for us?
-    var oldValue = _lastValue;
-    _lastValue = value;
+    if (value is! List) value = null;
 
-    if (value is! List) {
-      value = [];
-    }
-
+    var oldValue = iteratedValue;
     unobserve();
     iteratedValue = value;
 
-    if (value is Observable) {
-      _sub = value.changes.listen(_handleChanges);
+    if (iteratedValue is Observable) {
+      _sub = iteratedValue.changes.listen(_handleChanges);
     }
 
-    int addedCount = iteratedValue.length;
-    var removedCount = oldValue is List ? (oldValue as List).length : 0;
-    if (addedCount == 0 && removedCount == 0) return; // nothing to do.
+    var splices = calculateSplices(
+        iteratedValue != null ? iteratedValue : [],
+        oldValue != null ? oldValue : []);
 
-    _handleChanges([new ListChangeRecord(0, addedCount: addedCount,
-        removedCount: removedCount)]);
+    if (splices.length > 0) _handleChanges(splices);
+
+    if (inputs.length == 0) {
+      close();
+      _mdv(_templateElement)._templateIterator = null;
+    }
   }
 
   Node getTerminatorAt(int index) {
     if (index == -1) return _templateElement;
     var terminator = terminators[index];
     if (terminator is Element && (terminator as Element).isTemplate &&
         !identical(terminator, _templateElement)) {
       var subIterator = _mdv(terminator)._templateIterator;
       if (subIterator != null) {
         return subIterator.getTerminatorAt(subIterator.terminators.length - 1);
@@ skipping 51 matching lines @@
       return delegate.getInstanceModel(_templateElement, model);
     }
     return model;
   }
 
   DocumentFragment getInstanceFragment(model, BindingDelegate delegate) {
     return _templateElement.createInstance(model, delegate);
   }
 
   void _handleChanges(Iterable<ChangeRecord> splices) {
+    if (closed) return;
+
     splices = splices.where((s) => s is ListChangeRecord);
 
     var template = _templateElement;
     var delegate = template.bindingDelegate;
 
     if (template.parentNode == null || template.document.window == null) {
-      abandon();
+      close();
       // TODO(jmesserly): MDV calls templateIteratorTable.delete(this) here,
       // but I think that's a no-op because only nodes are used as keys.
       // See https://github.com/Polymer/mdv/pull/114.
       return;
     }
 
     // TODO(jmesserly): IdentityMap matches JS semantics, but it's O(N) right
     // now. See http://dartbug.com/4161.
     var instanceCache = new IdentityMap();
     var removeDelta = 0;
@@ skipping 29 matching lines @@
       instanceNodes.forEach(_unbindAllRecursively);
     }
   }
 
   void unobserve() {
     if (_sub == null) return;
     _sub.cancel();
     _sub = null;
   }
 
-  void abandon() {
+  void close() {
+    if (closed) return;
+
     unobserve();
-    _valueBinding.cancel();
     terminators.clear();
     inputs.dispose();
+    closed = true;
   }
 
   static void _unbindAllRecursively(Node node) {
     var nodeExt = _mdv(node);
     nodeExt._templateInstance = null;
     if (node is Element && (node as Element).isTemplate) {
       // Make sure we stop observing when we remove an element.
       var templateIterator = nodeExt._templateIterator;
       if (templateIterator != null) {
-        templateIterator.abandon();
+        templateIterator.close();
         nodeExt._templateIterator = null;
       }
     }
 
     _nodeOrCustom(node).unbindAll();
     for (var c = node.firstChild; c != null; c = c.nextNode) {
       _unbindAllRecursively(c);
     }
   }
 }