Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 19485008: Replace CONSTANT_FUNCTION by CONSTANT (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/bootstrapper.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1321 matching lines...) Expand 10 before | Expand all | Expand 10 after
1332 Object* value = js_obj->RawFastPropertyAt(index); 1332 Object* value = js_obj->RawFastPropertyAt(index);
1333 if (k != heap_->hidden_string()) { 1333 if (k != heap_->hidden_string()) {
1334 SetPropertyReference(js_obj, entry, k, value); 1334 SetPropertyReference(js_obj, entry, k, value);
1335 } else { 1335 } else {
1336 TagObject(value, "(hidden properties)"); 1336 TagObject(value, "(hidden properties)");
1337 SetInternalReference(js_obj, entry, "hidden_properties", value); 1337 SetInternalReference(js_obj, entry, "hidden_properties", value);
1338 } 1338 }
1339 } 1339 }
1340 break; 1340 break;
1341 } 1341 }
1342 case CONSTANT_FUNCTION: 1342 case CONSTANT:
1343 SetPropertyReference( 1343 SetPropertyReference(
1344 js_obj, entry, 1344 js_obj, entry,
1345 descs->GetKey(i), descs->GetConstantFunction(i)); 1345 descs->GetKey(i), descs->GetConstant(i));
1346 break; 1346 break;
1347 case CALLBACKS: 1347 case CALLBACKS:
1348 ExtractAccessorPairProperty( 1348 ExtractAccessorPairProperty(
1349 js_obj, entry, 1349 js_obj, entry,
1350 descs->GetKey(i), descs->GetValue(i)); 1350 descs->GetKey(i), descs->GetValue(i));
1351 break; 1351 break;
1352 case NORMAL: // only in slow mode 1352 case NORMAL: // only in slow mode
1353 case HANDLER: // only in lookup results, not in descriptors 1353 case HANDLER: // only in lookup results, not in descriptors
1354 case INTERCEPTOR: // only in lookup results, not in descriptors 1354 case INTERCEPTOR: // only in lookup results, not in descriptors
1355 break; 1355 break;
(...skipping 1337 matching lines...) Expand 10 before | Expand all | Expand 10 after
2693 2693
2694 2694
2695 void HeapSnapshotJSONSerializer::SortHashMap( 2695 void HeapSnapshotJSONSerializer::SortHashMap(
2696 HashMap* map, List<HashMap::Entry*>* sorted_entries) { 2696 HashMap* map, List<HashMap::Entry*>* sorted_entries) {
2697 for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p)) 2697 for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p))
2698 sorted_entries->Add(p); 2698 sorted_entries->Add(p);
2699 sorted_entries->Sort(SortUsingEntryValue); 2699 sorted_entries->Sort(SortUsingEntryValue);
2700 } 2700 }
2701 2701
2702 } } // namespace v8::internal 2702 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698