Issue 1948373002: [MD History] Add routing for synced devices page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1948373002: [MD History] Add routing for synced devices page. (Closed)

Created:
4 years, 7 months ago by calamity

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@mdh_fuckit_refactor_it_all

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[MD History] Add routing for synced devices page. This CL enables users to navigate to chrome://history/openTabs to see their synced devices. The URL bar also updates when the synced device button is clicked in the sidebar. This CL adds carbon-route and its dependencies to the build. BUG=609502

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -5 lines)			Patch
M	chrome/browser/resources/md_history/app.html	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/resources/md_history/app.js	View	3 chunks	+18 lines, -1 line	0 comments	Download
M	chrome/browser/resources/md_history/side_bar.html	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/md_history/side_bar.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/webui/resources/polymer_resources.grdp	View	2 chunks	+30 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1932413003 Patch 160001