Issue 19482003: ShortcutManager constructor: Added DCHECK for UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19482003: ShortcutManager constructor: Added DCHECK for UI thread. (Closed)

Created:
7 years, 5 months ago by Matt Giuca

Modified:
7 years, 4 months ago

Reviewers:
benwells, Paweł Hajdan Jr.

CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

ShortcutManager, TestingProfile constructors: Added DCHECK for UI thread. Profiles should only be created on the UI thread. Previously the DCHECK did not work due to http://crbug.com/251191. BUG=251191 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215768

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	chrome/browser/apps/shortcut_manager.cc	View	1 2 3	2 chunks	+6 lines, -3 lines	0 comments	Download
	M	chrome/test/base/testing_profile.cc	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Matt Giuca

phajdan.jr: I added the DCHECK to TestingProfile, as requested in https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/AR9Ti7eyxys.

7 years, 4 months ago (2013-08-05 06:59:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/19482003/27001

7 years, 4 months ago (2013-08-06 00:35:03 UTC) #5

Message was sent while issue was closed.

Change committed as 215768