Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2579)

Unified Diff: build/android/pylib/utils/run_tests_helper.py

Issue 19479002: [Android] Clean up gtest filtering logic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed all comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/test_runner.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/utils/run_tests_helper.py
diff --git a/build/android/pylib/utils/run_tests_helper.py b/build/android/pylib/utils/run_tests_helper.py
index eefc03bfb90698f63a9ff996c46f196237270c16..60823fcd4cd657c8a7dd3720fc3e199059cf1e57 100644
--- a/build/android/pylib/utils/run_tests_helper.py
+++ b/build/android/pylib/utils/run_tests_helper.py
@@ -31,14 +31,6 @@ class CustomFormatter(logging.Formatter):
return '%s %ss %s' % (record.levelname[0], timediff.rjust(4), msg)
-def GetExpectations(file_name):
- """Returns a list of test names in the |file_name| test expectations file."""
- if not file_name or not os.path.exists(file_name):
- return []
- return [x for x in [x.strip() for x in file(file_name).readlines()]
- if x and x[0] != '#']
-
-
def SetLogLevel(verbose_count):
"""Sets log level as |verbose_count|."""
log_level = logging.WARNING # Default.
« no previous file with comments | « build/android/pylib/gtest/test_runner.py ('k') | build/android/test_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698