[Android] Clean up gtest filtering logic.

[Android] Clean up gtest filtering logic.

Apply gtest_filter option to tests obtained from the device.

BUG=246871
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212229

[craigdh, 2013-07-17 21:27:02]

lgtm with comments.

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
File build/android/pylib/gtest/dispatch.py (right):

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
build/android/pylib/gtest/dispatch.py:213: if not filter_file_path or not
os.path.exists(filter_file_path):
logging.info that no filter file was found?

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
build/android/pylib/gtest/dispatch.py:228: runner_factory: Callable that takes a
devices and returns a TestRunner.
devices -> device and shard index

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
build/android/pylib/gtest/dispatch.py:243: raise Exception('No device available
to get the list of tests.')
This is a pain right now, because if there is an issue in the test scripts it
often shows up when we first install (which is here), but we lose the stack
trace because we only print the exception message. If we fail on the last device
we should just raise that exception instead of catching it and raising our own.

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
build/android/pylib/gtest/dispatch.py:268: if any([test_case.startswith(prefix)
or test.startswith(prefix) for prefix
lose the continue, just do:

if not any(...):
  filtered_tests.append(t)

[frankf, 2013-07-17 22:18:54]

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
File build/android/pylib/gtest/dispatch.py (right):

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
build/android/pylib/gtest/dispatch.py:213: if not filter_file_path or not
os.path.exists(filter_file_path):
On 2013/07/17 21:27:03, craigdh wrote:
> logging.info that no filter file was found?

Done.

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
build/android/pylib/gtest/dispatch.py:228: runner_factory: Callable that takes a
devices and returns a TestRunner.
On 2013/07/17 21:27:03, craigdh wrote:
> devices -> device and shard index

Done.

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
build/android/pylib/gtest/dispatch.py:243: raise Exception('No device available
to get the list of tests.')
The issue is that we're catching too general exception. We should only catch
android_commands specific ones.

On 2013/07/17 21:27:03, craigdh wrote:
> This is a pain right now, because if there is an issue in the test scripts it
> often shows up when we first install (which is here), but we lose the stack
> trace because we only print the exception message. If we fail on the last
device
> we should just raise that exception instead of catching it and raising our
own.

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
build/android/pylib/gtest/dispatch.py:268: if any([test_case.startswith(prefix)
or test.startswith(prefix) for prefix
On 2013/07/17 21:27:03, craigdh wrote:
> lose the continue, just do:
> 
> if not any(...):
>   filtered_tests.append(t)

Done.

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
File build/android/pylib/gtest/test_runner.py (left):

https://codereview.chromium.org/19479002/diff/7001/build/android/pylib/gtest/...
build/android/pylib/gtest/test_runner.py:130: def GetDisabledTests(self):
Improve --gtest help

[commit-bot: I haz the power, 2013-07-18 03:21:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/frankf@chromium.org/19479002/14001

[commit-bot: I haz the power, 2013-07-18 03:42:52]

Change committed as 212229