Source/core/editing/DeleteSelectionCommand.cpp - Issue 19477010: Background color applied on a selection of text is lost when the selection is deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/DeleteSelectionCommand.cpp

Issue 19477010: Background color applied on a selection of text is lost when the selection is deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments addressed Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/DeleteSelectionCommand.cpp

diff --git a/Source/core/editing/DeleteSelectionCommand.cpp b/Source/core/editing/DeleteSelectionCommand.cpp

index adf8e0674dcf46ac9f7826a26768df949bf4fc2a..3536ec6b81367780b85eb9f4fc37e033e56e55e7 100644

--- a/Source/core/editing/DeleteSelectionCommand.cpp

+++ b/Source/core/editing/DeleteSelectionCommand.cpp

@@ -292,7 +292,7 @@ void DeleteSelectionCommand::saveTypingStyleState()

return;

// Figure out the typing style in effect before the delete is done.

- m_typingStyle = EditingStyle::create(m_selectionToDelete.start());

+ m_typingStyle = EditingStyle::create(m_selectionToDelete.start(), EditingStyle::EditingPropertiesInEffect);

m_typingStyle->removeStyleAddedByNode(enclosingAnchorElement(m_selectionToDelete.start()));

// If we're deleting into a Mail blockquote, save the style at end() instead of start()

« no previous file with comments | « LayoutTests/editing/style/background-color-retained-expected.txt ('k') | no next file » | no next file with comments »