Chromium Code Reviews
Help | Chromium Project | Sign in
(59)

Issue 19475005: Produce error when bindings are used under the head element (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by Siggi Cherem (dart-lang)
Modified:
1 year, 10 months ago
Reviewers:
John Messerly
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Produce error when bindings are used under the head element R=jmesserly@google.com Committed: https://github.com/dart-lang/web-ui/commit/68404b6

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M lib/src/analyzer.dart View 4 chunks +15 lines, -0 lines 6 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 6 (0 generated)
Siggi Cherem (dart-lang)
This is for Web-UI, to prevent the compilerAssert error later on.
1 year, 10 months ago (2013-07-23 17:32:22 UTC) #1
John Messerly
lgtm https://chromiumcodereview.appspot.com/19475005/diff/1/lib/src/analyzer.dart File lib/src/analyzer.dart (right): https://chromiumcodereview.appspot.com/19475005/diff/1/lib/src/analyzer.dart#newcode186 lib/src/analyzer.dart:186: if (node.tagName == 'head') { alternatively, we could ...
1 year, 10 months ago (2013-07-23 20:39:04 UTC) #2
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/19475005/diff/1/lib/src/analyzer.dart File lib/src/analyzer.dart (right): https://chromiumcodereview.appspot.com/19475005/diff/1/lib/src/analyzer.dart#newcode186 lib/src/analyzer.dart:186: if (node.tagName == 'head') { On 2013/07/23 20:39:04, John ...
1 year, 10 months ago (2013-07-23 21:03:04 UTC) #3
John Messerly
https://chromiumcodereview.appspot.com/19475005/diff/1/lib/src/analyzer.dart File lib/src/analyzer.dart (right): https://chromiumcodereview.appspot.com/19475005/diff/1/lib/src/analyzer.dart#newcode186 lib/src/analyzer.dart:186: if (node.tagName == 'head') { On 2013/07/23 21:03:04, Siggi ...
1 year, 10 months ago (2013-07-23 21:04:03 UTC) #4
Siggi Cherem (dart-lang)
thx https://chromiumcodereview.appspot.com/19475005/diff/1/lib/src/analyzer.dart File lib/src/analyzer.dart (right): https://chromiumcodereview.appspot.com/19475005/diff/1/lib/src/analyzer.dart#newcode186 lib/src/analyzer.dart:186: if (node.tagName == 'head') { On 2013/07/23 21:04:03, ...
1 year, 10 months ago (2013-07-23 21:07:04 UTC) #5
Siggi Cherem (dart-lang)
1 year, 10 months ago (2013-07-23 21:08:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r68404b6 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be