Extension settings: Should close the lid of a trash can.

Extension settings: Should not focus on buttons by mouse click.

We don't need the focus-buttons-by-mouse behavior in the extension
settings page.

BUG=257544, 262925
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213340

[tkent, 2013-07-17 00:36:20]

arv, would you review this too?

[arv (Not doing code reviews), 2013-07-17 15:56:03]

On 2013/07/17 00:36:20, tkent wrote:
> arv, would you review this too?

Actually, this looks like it is working as intended.

The button is still focused when you close the button.

[tkent, 2013-07-17 23:35:11]

> The button is still focused when you close the button.

Do you mean the trash can should be focused by mouse click, and should keep
focused when we close the dialog?

[arv (Not doing code reviews), 2013-07-18 17:57:39]

On 2013/07/17 23:35:11, tkent wrote:
> > The button is still focused when you close the button.
> 
> Do you mean the trash can should be focused by mouse click, and should keep
> focused when we close the dialog?

Yes, buttons should be focused by mouse click.

[tkent, 2013-07-23 01:05:10]

Now this CL covers crbug.com/262925 too.

[arv (Not doing code reviews), 2013-07-23 17:34:53]

LGTM

Makes me sad that we make buttons focusable by default and then end up disabling
that usability improvement in all of our WebUI.

[commit-bot: I haz the power, 2013-07-23 23:31:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/19471002/1

[tkent, 2013-07-23 23:38:41]

> Makes me sad that we make buttons focusable by default and then end up
disabling
> that usability improvement in all of our WebUI.

The main issue is just appearance.  I think proposing :focus-by-mouse pseudo
class to CSS UI module is a right way to fix these issues.

[commit-bot: I haz the power, 2013-07-24 04:45:40]

Change committed as 213340