Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 19463011: Cleanup 'git cl status' in preparation to add new features. (Closed)

Created:
7 years, 5 months ago by M-A Ruel
Modified:
7 years, 5 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Cleanup 'git cl status' in preparation to add new features. Reduce the number of conditions and use more early exits to reduce the number of code paths. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=213173

Patch Set 1 #

Patch Set 2 : cleaner than clean #

Patch Set 3 : Using double quotes was an error #

Patch Set 4 : trying harder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M git_cl.py View 1 2 2 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
7 years, 5 months ago (2013-07-22 17:57:30 UTC) #1
iannucci
Patchset 3 is bad :(
7 years, 5 months ago (2013-07-23 01:57:29 UTC) #2
M-A Ruel
On 2013/07/23 01:57:29, iannucci wrote: > Patchset 3 is bad :( Patchset 4 is ok.
7 years, 5 months ago (2013-07-23 13:40:23 UTC) #3
iannucci
lgtm
7 years, 5 months ago (2013-07-23 18:16:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/19463011/10001
7 years, 5 months ago (2013-07-23 18:29:07 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 18:30:58 UTC) #6
Message was sent while issue was closed.
Change committed as 213173

Powered by Google App Engine
This is Rietveld 408576698