Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1946053002: Fixes to DBus GATT components. (Closed)

Created:
4 years, 7 months ago by rkc
Modified:
4 years, 7 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes to DBus GATT components. These are some fixes to how we use DBus to communicate with BlueZ for GATT server functionality. The fixes here are, .) We now call the Register/Unregister functions on the adapter object. .) The format of the return from ObjectManager.GetManagedObjects is fixed. It was incorrectly using structs where it should use dictionaries. .) Adds the missing is_primary field to services. R=scheib@chromium.org BUG=596742 Committed: https://crrev.com/dcf1c729128319dae20d90e78ef52629a4538008 Cr-Commit-Position: refs/heads/master@{#391424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -85 lines) Patch
M device/bluetooth/bluez/bluetooth_adapter_bluez.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.cc View 2 chunks +31 lines, -32 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc View 12 chunks +28 lines, -20 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_manager_client.h View 1 chunk +7 lines, -4 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_manager_client.cc View 7 chunks +24 lines, -13 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_service_service_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_service_service_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_service_service_provider_impl.h View 2 chunks +6 lines, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_service_service_provider_impl.cc View 3 chunks +10 lines, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_manager_client.h View 1 chunk +4 lines, -2 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_manager_client.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
rkc
4 years, 7 months ago (2016-05-04 00:30:17 UTC) #1
scheib
LGTM
4 years, 7 months ago (2016-05-04 01:21:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946053002/1
4 years, 7 months ago (2016-05-04 01:30:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 02:30:44 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 02:33:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcf1c729128319dae20d90e78ef52629a4538008
Cr-Commit-Position: refs/heads/master@{#391424}

Powered by Google App Engine
This is Rietveld 408576698