Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 19460020: Fix NPAPI and native messaging hosts to cope with NULL pairing registry. (Closed)

Created:
7 years, 4 months ago by Jamie
Modified:
7 years, 4 months ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix NPAPI and native messaging hosts to cope with NULL pairing registry. Since there are no Windows or Mac pairing registry delegates yet, the host plugin currently crashes when the web-app starts up on those platforms. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -19 lines) Patch
M remoting/host/plugin/host_script_object.cc View 3 chunks +23 lines, -10 lines 0 comments Download
M remoting/host/setup/native_messaging_host.cc View 3 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jamie
ptal
7 years, 4 months ago (2013-07-24 01:42:12 UTC) #1
Lambros
lgtm
7 years, 4 months ago (2013-07-24 01:45:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/19460020/1
7 years, 4 months ago (2013-07-24 01:48:22 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-07-24 10:01:24 UTC) #4
Message was sent while issue was closed.
Change committed as 213381

Powered by Google App Engine
This is Rietveld 408576698