Issue 19446002: Small XSSAuditor cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19446002: Small XSSAuditor cleanup. (Closed)

Created:
7 years, 5 months ago by Tom Sepez

Modified:
7 years, 5 months ago

Reviewers:
Mike West, abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Small XSSAuditor cleanup. Avoid keeping a string for longer than necessary, and avoid the possibility of checking for it more than once. Instead, check once and keep that result. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154354

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	Source/core/html/parser/XSSAuditor.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/html/parser/XSSAuditor.cpp	View		4 chunks	+5 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

Tom Sepez

Adam, noticed this while trying to see what it would take to make the XSSAuditor ...

7 years, 5 months ago (2013-07-16 23:29:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/19446002/1

7 years, 5 months ago (2013-07-17 00:35:04 UTC) #3

Message was sent while issue was closed.

Change committed as 154354