Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: content/common/indexed_db/indexed_db_key.cc

Issue 19442002: Convert to new WebIDBTypes enums and accessors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix content/common/DEPS Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/indexed_db/indexed_db_key.h ('k') | content/common/indexed_db/indexed_db_key_path.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/indexed_db/indexed_db_key.cc
diff --git a/content/common/indexed_db/indexed_db_key.cc b/content/common/indexed_db/indexed_db_key.cc
index 30bc8b3f6738d7aa91e87423fac119f5aff5e597..2fefb398f65b39955258347d35a27fe08ba2dc1d 100644
--- a/content/common/indexed_db/indexed_db_key.cc
+++ b/content/common/indexed_db/indexed_db_key.cc
@@ -6,12 +6,21 @@
#include <string>
#include "base/logging.h"
+#include "third_party/WebKit/public/platform/WebIDBKey.h"
#include "third_party/WebKit/public/platform/WebString.h"
#include "third_party/WebKit/public/platform/WebVector.h"
namespace content {
using WebKit::WebIDBKey;
+using WebKit::WebIDBKeyType;
+using WebKit::WebIDBKeyTypeArray;
+using WebKit::WebIDBKeyTypeDate;
+using WebKit::WebIDBKeyTypeInvalid;
+using WebKit::WebIDBKeyTypeMin;
+using WebKit::WebIDBKeyTypeNull;
+using WebKit::WebIDBKeyTypeNumber;
+using WebKit::WebIDBKeyTypeString;
using WebKit::WebVector;
namespace {
@@ -27,20 +36,20 @@ static size_t CalculateArraySize(const IndexedDBKey::KeyArray& keys) {
}
static size_t CalculateKeySize(const WebIDBKey& key) {
- switch (key.type()) {
- case WebIDBKey::ArrayType: {
+ switch (key.keyType()) {
+ case WebIDBKeyTypeArray: {
const WebVector<WebIDBKey>& array = key.array();
size_t total = 0;
for (size_t i = 0; i < array.size(); ++i)
total += CalculateKeySize(array[i]);
return kOverheadSize + total;
}
- case WebIDBKey::StringType:
+ case WebIDBKeyTypeString:
return kOverheadSize +
(key.string().length() * sizeof(string16::value_type));
- case WebIDBKey::DateType:
- case WebIDBKey::NumberType:
+ case WebIDBKeyTypeDate:
+ case WebIDBKeyTypeNumber:
return kOverheadSize + sizeof(double);
default:
@@ -62,7 +71,7 @@ static IndexedDBKey::KeyArray CopyKeyArray(const T& array) {
static IndexedDBKey::KeyArray CopyKeyArray(const WebIDBKey& other) {
IndexedDBKey::KeyArray result;
- if (other.type() == WebIDBKey::ArrayType) {
+ if (other.keyType() == WebIDBKeyTypeArray) {
result = CopyKeyArray(other.array());
}
return result;
@@ -70,45 +79,45 @@ static IndexedDBKey::KeyArray CopyKeyArray(const WebIDBKey& other) {
} // namespace
IndexedDBKey::IndexedDBKey()
- : type_(WebIDBKey::NullType),
+ : type_(WebIDBKeyTypeNull),
date_(0),
number_(0),
size_estimate_(kOverheadSize) {}
-IndexedDBKey::IndexedDBKey(WebIDBKey::Type type)
+IndexedDBKey::IndexedDBKey(WebIDBKeyType type)
: type_(type), date_(0), number_(0), size_estimate_(kOverheadSize) {
- DCHECK(type == WebIDBKey::NullType || type == WebIDBKey::InvalidType);
+ DCHECK(type == WebIDBKeyTypeNull || type == WebIDBKeyTypeInvalid);
}
-IndexedDBKey::IndexedDBKey(double number, WebIDBKey::Type type)
+IndexedDBKey::IndexedDBKey(double number, WebIDBKeyType type)
: type_(type),
date_(number),
number_(number),
size_estimate_(kOverheadSize + sizeof(number)) {
- DCHECK(type == WebIDBKey::NumberType || type == WebIDBKey::DateType);
+ DCHECK(type == WebIDBKeyTypeNumber || type == WebIDBKeyTypeDate);
}
IndexedDBKey::IndexedDBKey(const KeyArray& keys)
- : type_(WebIDBKey::ArrayType),
+ : type_(WebIDBKeyTypeArray),
array_(CopyKeyArray(keys)),
date_(0),
number_(0),
size_estimate_(kOverheadSize + CalculateArraySize(keys)) {}
IndexedDBKey::IndexedDBKey(const string16& key)
- : type_(WebIDBKey::StringType),
+ : type_(WebIDBKeyTypeString),
string_(key),
size_estimate_(kOverheadSize +
(key.length() * sizeof(string16::value_type))) {}
IndexedDBKey::IndexedDBKey(const WebIDBKey& key)
- : type_(key.type()),
+ : type_(key.keyType()),
array_(CopyKeyArray(key)),
- string_(key.type() == WebIDBKey::StringType
+ string_(key.keyType() == WebIDBKeyTypeString
? static_cast<string16>(key.string())
: string16()),
- date_(key.type() == WebIDBKey::DateType ? key.date() : 0),
- number_(key.type() == WebIDBKey::NumberType ? key.number() : 0),
+ date_(key.keyType() == WebIDBKeyTypeDate ? key.date() : 0),
+ number_(key.keyType() == WebIDBKeyTypeNumber ? key.number() : 0),
size_estimate_(CalculateKeySize(key)) {}
IndexedDBKey::~IndexedDBKey() {}
@@ -120,7 +129,7 @@ int IndexedDBKey::Compare(const IndexedDBKey& other) const {
return type_ > other.type_ ? -1 : 1;
switch (type_) {
- case WebIDBKey::ArrayType:
+ case WebIDBKeyTypeArray:
for (size_t i = 0; i < array_.size() && i < other.array_.size(); ++i) {
if (int result = array_[i].Compare(other.array_[i]))
return result;
@@ -130,15 +139,15 @@ int IndexedDBKey::Compare(const IndexedDBKey& other) const {
if (array_.size() > other.array_.size())
return 1;
return 0;
- case WebIDBKey::StringType:
+ case WebIDBKeyTypeString:
return -other.string_.compare(string_);
- case WebIDBKey::DateType:
+ case WebIDBKeyTypeDate:
return (date_ < other.date_) ? -1 : (date_ > other.date_) ? 1 : 0;
- case WebIDBKey::NumberType:
+ case WebIDBKeyTypeNumber:
return (number_ < other.number_) ? -1 : (number_ > other.number_) ? 1 : 0;
- case WebIDBKey::InvalidType:
- case WebIDBKey::NullType:
- case WebIDBKey::MinType:
+ case WebIDBKeyTypeInvalid:
+ case WebIDBKeyTypeNull:
+ case WebIDBKeyTypeMin:
NOTREACHED();
return 0;
}
@@ -155,10 +164,10 @@ bool IndexedDBKey::IsEqual(const IndexedDBKey& other) const {
}
bool IndexedDBKey::IsValid() const {
- if (type_ == WebIDBKey::InvalidType || type_ == WebIDBKey::NullType)
+ if (type_ == WebIDBKeyTypeInvalid || type_ == WebIDBKeyTypeNull)
return false;
- if (type_ == WebIDBKey::ArrayType) {
+ if (type_ == WebIDBKeyTypeArray) {
for (size_t i = 0; i < array_.size(); i++) {
if (!array_[i].IsValid())
return false;
@@ -170,19 +179,19 @@ bool IndexedDBKey::IsValid() const {
IndexedDBKey::operator WebIDBKey() const {
switch (type_) {
- case WebIDBKey::ArrayType:
+ case WebIDBKeyTypeArray:
return WebIDBKey::createArray(array_);
- case WebIDBKey::StringType:
+ case WebIDBKeyTypeString:
return WebIDBKey::createString(string_);
- case WebIDBKey::DateType:
+ case WebIDBKeyTypeDate:
return WebIDBKey::createDate(date_);
- case WebIDBKey::NumberType:
+ case WebIDBKeyTypeNumber:
return WebIDBKey::createNumber(number_);
- case WebIDBKey::InvalidType:
+ case WebIDBKeyTypeInvalid:
return WebIDBKey::createInvalid();
- case WebIDBKey::NullType:
+ case WebIDBKeyTypeNull:
return WebIDBKey::createNull();
- case WebIDBKey::MinType:
+ case WebIDBKeyTypeMin:
NOTREACHED();
return WebIDBKey::createInvalid();
}
« no previous file with comments | « content/common/indexed_db/indexed_db_key.h ('k') | content/common/indexed_db/indexed_db_key_path.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698