Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 19442002: Convert to new WebIDBTypes enums and accessors (Closed)

Created:
7 years, 5 months ago by jamesr
Modified:
7 years, 5 months ago
Reviewers:
alecflett, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Convert to new WebIDBTypes enums and accessors This way we can verify with DEPS that the content/(common|browser)/ code is only depending on enums and not linking against Blink symbols. Some of the code in content/common/ that reaches into WebIDBKey(Path) still needs to be pulled out into content/child/ BUG=237267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212237

Patch Set 1 #

Patch Set 2 : fix content/common/DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -156 lines) Patch
M content/browser/DEPS View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding.cc View 10 chunks +37 lines, -27 lines 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc View 6 chunks +22 lines, -22 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/proxy_webidbcursor_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/proxy_webidbcursor_impl_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/common/DEPS View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/indexed_db/indexed_db_key.h View 4 chunks +10 lines, -6 lines 0 comments Download
M content/common/indexed_db/indexed_db_key.cc View 8 chunks +42 lines, -33 lines 0 comments Download
M content/common/indexed_db/indexed_db_key_path.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/indexed_db/indexed_db_key_path.cc View 5 chunks +17 lines, -14 lines 0 comments Download
M content/common/indexed_db/indexed_db_key_range.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/indexed_db/indexed_db_key_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/indexed_db/indexed_db_param_traits.cc View 4 chunks +32 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
Depends on https://codereview.chromium.org/19316002/
7 years, 5 months ago (2013-07-16 23:19:13 UTC) #1
jamesr
On 2013/07/16 23:19:13, jamesr wrote: > Depends on https://codereview.chromium.org/19316002/ https://codereview.chromium.org/19316002/ landed as blink r154358 and ...
7 years, 5 months ago (2013-07-17 17:37:34 UTC) #2
alecflett
lgtm
7 years, 5 months ago (2013-07-17 18:12:57 UTC) #3
jamesr
Thanks! jam - could you approve the content/*/DEPS changes?
7 years, 5 months ago (2013-07-17 18:14:14 UTC) #4
jam
lgtm
7 years, 5 months ago (2013-07-17 19:55:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/19442002/4001
7 years, 5 months ago (2013-07-17 20:25:52 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=136756
7 years, 5 months ago (2013-07-18 01:59:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/19442002/4001
7 years, 5 months ago (2013-07-18 02:07:34 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 04:02:30 UTC) #9
Message was sent while issue was closed.
Change committed as 212237

Powered by Google App Engine
This is Rietveld 408576698