Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 19435002: Display "Imported" folder name again. (Closed)

Created:
7 years, 5 months ago by tfarina
Modified:
7 years, 5 months ago
Reviewers:
gab
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Display "Imported" folder name again. During the conversion to out of process this seems to have popped out. See https://chromiumcodereview.appspot.com/17379006. BUG=256162 TEST=open chrome, bookmark some pages, go to Bookmark Manager, export the bookmarks to HTML file. Then, import it, there should be a folder named "Imported" again. R=gab@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212409

Patch Set 1 #

Patch Set 2 : add IDS_IMPORT_FROM_ICEWEASEL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/importer/external_process_importer_client.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Gabriel, could you review this to me? Thanks,
7 years, 5 months ago (2013-07-16 22:39:44 UTC) #1
gab
lgtm, thanks! From https://code.google.com/p/chromium/codesearch#search/&q=file:src/chrome/browser/importer%20%22IDS_%22&sq=package:chromium&type=cs it looks like we might also be missing IDS_IMPORT_FROM_ICE_WEASEL in that ...
7 years, 5 months ago (2013-07-16 23:50:42 UTC) #2
tfarina
Done.
7 years, 5 months ago (2013-07-17 00:01:05 UTC) #3
gab
ping? committing this? Thanks! Gab
7 years, 5 months ago (2013-07-18 16:17:36 UTC) #4
tfarina
On Thu, Jul 18, 2013 at 1:17 PM, <gab@chromium.org> wrote: > ping? committing this? > ...
7 years, 5 months ago (2013-07-18 16:26:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/19435002/8001
7 years, 5 months ago (2013-07-18 20:11:33 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 20:25:25 UTC) #7
Message was sent while issue was closed.
Change committed as 212409

Powered by Google App Engine
This is Rietveld 408576698