Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1942353002: (reland) Move permission.mojom from WebKit/public/platform/ to components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_uma_util.h" 5 #include "chrome/browser/permissions/permission_uma_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 209
210 // In order to gauge the compatibility risk of implementing an improved 210 // In order to gauge the compatibility risk of implementing an improved
211 // iframe permissions security model, we would like to know the ratio of 211 // iframe permissions security model, we would like to know the ratio of
212 // same-origin to cross-origin permission requests. Our estimate of this 212 // same-origin to cross-origin permission requests. Our estimate of this
213 // ratio could be somewhat biased by repeated requests coming from a 213 // ratio could be somewhat biased by repeated requests coming from a
214 // single frame, but we expect this to be insignificant. 214 // single frame, but we expect this to be insignificant.
215 if (requesting_origin.GetOrigin() != embedding_origin.GetOrigin()) { 215 if (requesting_origin.GetOrigin() != embedding_origin.GetOrigin()) {
216 content::PermissionManager* manager = profile->GetPermissionManager(); 216 content::PermissionManager* manager = profile->GetPermissionManager();
217 if (!manager) 217 if (!manager)
218 return; 218 return;
219 blink::mojom::PermissionStatus embedding_permission_status = 219 permissions::mojom::PermissionStatus embedding_permission_status =
220 manager->GetPermissionStatus(permission, embedding_origin, 220 manager->GetPermissionStatus(permission, embedding_origin,
221 embedding_origin); 221 embedding_origin);
222 222
223 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet( 223 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(
224 "Permissions.Requested.CrossOrigin_" + 224 "Permissions.Requested.CrossOrigin_" +
225 PermissionUtil::GetPermissionString(permission), 225 PermissionUtil::GetPermissionString(permission),
226 1, static_cast<int>(blink::mojom::PermissionStatus::LAST), 226 1, static_cast<int>(permissions::mojom::PermissionStatus::LAST),
227 static_cast<int>(blink::mojom::PermissionStatus::LAST) + 1, 227 static_cast<int>(permissions::mojom::PermissionStatus::LAST) + 1,
228 base::HistogramBase::kUmaTargetedHistogramFlag); 228 base::HistogramBase::kUmaTargetedHistogramFlag);
229 histogram->Add(static_cast<int>(embedding_permission_status)); 229 histogram->Add(static_cast<int>(embedding_permission_status));
230 } else { 230 } else {
231 UMA_HISTOGRAM_ENUMERATION( 231 UMA_HISTOGRAM_ENUMERATION(
232 "Permissions.Requested.SameOrigin", 232 "Permissions.Requested.SameOrigin",
233 static_cast<base::HistogramBase::Sample>(permission), 233 static_cast<base::HistogramBase::Sample>(permission),
234 static_cast<base::HistogramBase::Sample>(PermissionType::NUM)); 234 static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
235 } 235 }
236 } 236 }
237 237
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 const std::vector<PermissionBubbleRequest*>& requests) { 283 const std::vector<PermissionBubbleRequest*>& requests) {
284 DCHECK(!requests.empty()); 284 DCHECK(!requests.empty());
285 PermissionBubbleType permission_prompt_type = PermissionBubbleType::MULTIPLE; 285 PermissionBubbleType permission_prompt_type = PermissionBubbleType::MULTIPLE;
286 if (requests.size() == 1) 286 if (requests.size() == 1)
287 permission_prompt_type = requests[0]->GetPermissionBubbleType(); 287 permission_prompt_type = requests[0]->GetPermissionBubbleType();
288 UMA_HISTOGRAM_ENUMERATION( 288 UMA_HISTOGRAM_ENUMERATION(
289 "Permissions.Prompt.Shown", 289 "Permissions.Prompt.Shown",
290 static_cast<base::HistogramBase::Sample>(permission_prompt_type), 290 static_cast<base::HistogramBase::Sample>(permission_prompt_type),
291 static_cast<base::HistogramBase::Sample>(PermissionBubbleType::NUM)); 291 static_cast<base::HistogramBase::Sample>(PermissionBubbleType::NUM));
292 } 292 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698