media/gpu/video_decode_accelerator_unittest.cc - Issue 1942123002: Plumb decoded video pixel format from GPU process to renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/video_decode_accelerator_unittest.cc

Issue 1942123002: Plumb decoded video pixel format from GPU process to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/gpu/ipc/client/gpu_video_decode_accelerator_host.h ('K') | « media/gpu/vaapi_video_decode_accelerator.cc ('k') | media/gpu/vt_video_decode_accelerator_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/gpu/video_decode_accelerator_unittest.cc

diff --git a/media/gpu/video_decode_accelerator_unittest.cc b/media/gpu/video_decode_accelerator_unittest.cc

index f9f271189ce02985d167631745cc1fe06b8f6550..27491e9693d4d1bbb139829b0be84f0963d78120 100644

--- a/media/gpu/video_decode_accelerator_unittest.cc

+++ b/media/gpu/video_decode_accelerator_unittest.cc

@@ -422,6 +422,7 @@ class GLRenderingVDAClient

// VideoDecodeAccelerator::Client implementation.

// The heart of the Client.

void ProvidePictureBuffers(uint32_t requested_num_of_buffers,

+ VideoPixelFormat format,

uint32_t textures_per_buffer,

const gfx::Size& dimensions,

uint32_t texture_target) override;

@@ -641,6 +642,7 @@ void GLRenderingVDAClient::CreateAndStartDecoder() {

void GLRenderingVDAClient::ProvidePictureBuffers(

uint32_t requested_num_of_buffers,

+ VideoPixelFormat pixel_format,

uint32_t textures_per_buffer,

const gfx::Size& dimensions,

uint32_t texture_target) {

@@ -665,7 +667,6 @@ void GLRenderingVDAClient::ProvidePictureBuffers(

base::Unretained(rendering_helper_), texture_id);

if (g_test_import) {

- media::VideoPixelFormat pixel_format = decoder_->GetOutputFormat();

if (pixel_format == media::PIXEL_FORMAT_UNKNOWN)

pixel_format = media::PIXEL_FORMAT_ARGB;

texture_ref = TextureRef::CreatePreallocated(