Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: media/gpu/v4l2_video_decode_accelerator.cc

Issue 1942123002: Plumb decoded video pixel format from GPU process to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/v4l2_video_decode_accelerator.cc
diff --git a/media/gpu/v4l2_video_decode_accelerator.cc b/media/gpu/v4l2_video_decode_accelerator.cc
index 410cd6ca536ad30038c3f43510b2c9455b852114..19ea4ad445008bb93445411aca8085a6dcc3aaf8 100644
--- a/media/gpu/v4l2_video_decode_accelerator.cc
+++ b/media/gpu/v4l2_video_decode_accelerator.cc
@@ -519,10 +519,6 @@ bool V4L2VideoDecodeAccelerator::TryToSetupDecodeOnSeparateThread(
return true;
}
-media::VideoPixelFormat V4L2VideoDecodeAccelerator::GetOutputFormat() const {
- return V4L2Device::V4L2PixFmtToVideoPixelFormat(egl_image_format_fourcc_);
-}
-
// static
media::VideoDecodeAccelerator::SupportedProfiles
V4L2VideoDecodeAccelerator::GetSupportedProfiles() {
@@ -2036,10 +2032,15 @@ bool V4L2VideoDecodeAccelerator::CreateOutputBuffers() {
DVLOG(3) << "CreateOutputBuffers(): ProvidePictureBuffers(): "
<< "buffer_count=" << buffer_count
<< ", coded_size=" << egl_image_size_.ToString();
+
+ DCHECK(egl_image_format_fourcc_);
+ VideoPixelFormat pixel_format =
+ V4L2Device::V4L2PixFmtToVideoPixelFormat(egl_image_format_fourcc_);
+
child_task_runner_->PostTask(
- FROM_HERE,
- base::Bind(&Client::ProvidePictureBuffers, client_, buffer_count, 1,
- egl_image_size_, device_->GetTextureTarget()));
+ FROM_HERE, base::Bind(&Client::ProvidePictureBuffers, client_,
+ buffer_count, pixel_format, 1, egl_image_size_,
+ device_->GetTextureTarget()));
// Wait for the client to call AssignPictureBuffers() on the Child thread.
// We do this, because if we continue decoding without finishing buffer

Powered by Google App Engine
This is Rietveld 408576698