Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 19392003: Limit dead resource capacity in Blink cache to 50%. (Closed)

Created:
7 years, 5 months ago by ppi
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Limit dead resource capacity in Blink cache to 50%. Blink resource cache distinguishes between live and dead resources depending on whether clients of the resources are still around. The cache capacity is defined in terms of total capacity and dead resource capacity - the part of total capacity that may be consumed by dead resources. Currently we explicitly set "max_dead_capacity = capacity;", i.e. we allow dead resources to potentially consume all of the cache space. While keeping some dead resources around makes sense from the performance perspective, allowing them to constitute a majority of cache space makes renderers that are used for long one-site multiple-pages browsing sessions bloat with resources of little value. This patch limits dead resource capacity to 50% of total cache capacity, putting a cap on dead resource bloat for long-lived renderers. BUG=260662 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/renderer_host/web_cache_manager.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ppi
Could you guys have a look?
7 years, 5 months ago (2013-07-16 17:43:23 UTC) #1
Nate Chapin
On 2013/07/16 17:43:23, ppi wrote: > Could you guys have a look? Seems reasonable, but ...
7 years, 5 months ago (2013-07-16 23:27:07 UTC) #2
abarth-chromium
(I'm not an OWNER either)
7 years, 5 months ago (2013-07-17 00:31:06 UTC) #3
jochen (gone - plz use gerrit)
Adding Tony who had concerns on the issue
7 years, 5 months ago (2013-07-17 08:17:15 UTC) #4
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-18 07:18:26 UTC) #5
ppi
Thanks!
7 years, 5 months ago (2013-07-18 12:57:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/19392003/1
7 years, 5 months ago (2013-07-18 12:58:34 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-18 19:22:28 UTC) #8
Message was sent while issue was closed.
Change committed as 212392

Powered by Google App Engine
This is Rietveld 408576698