Issue 19392002: Fixed PathUtils nits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19392002: Fixed PathUtils nits. (Closed)

Created:
7 years, 5 months ago by dierk

Modified:
7 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com, tfarina

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fixed PathUtils nits. Fixed PathUtils nits BUG= Committed: http://code.google.com/p/skia/source/detail?r=10108

Patch Set 1 #

Patch Set 2 : fixed binary_to_skbitmap identifier #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -29 lines)			Patch
	M	tests/PathUtilsTest.cpp	View	1	7 chunks	+26 lines, -29 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm You might find this useful: SkBitmap result; SkImageEncoder::EncodeFile("d:\\src\\foo.png", result, SkImageEncoder::kPNG_Type, 100);

7 years, 5 months ago (2013-07-16 16:09:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dierk@google.com/19392002/2001

7 years, 5 months ago (2013-07-16 16:12:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dierk@google.com/19392002/2001

7 years, 5 months ago (2013-07-16 16:13:31 UTC) #4

tfarina

7 years, 5 months ago (2013-07-16 17:08:04 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/19392002/diff/2001/tests/PathUtilsTest.cpp
File tests/PathUtilsTest.cpp (right):

https://codereview.chromium.org/19392002/diff/2001/tests/PathUtilsTest.cpp#ne...
tests/PathUtilsTest.cpp:13: #include "SkPathUtils.h"
can this be the first include?

https://codereview.chromium.org/19392002/diff/2001/tests/PathUtilsTest.cpp#ne...
tests/PathUtilsTest.cpp:17: #define SK_NUM_IT 100
can this be const int kNumIt = 100; instead?

Expand Messages | Collapse Messages