Issue 19388005: Do not call reinterpret_cast when converting from NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19388005: Do not call reinterpret_cast when converting from NULL. (Closed)

Created:
7 years, 5 months ago by Raphael Kubo da Costa (rakuco)

Modified:
7 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Chromium), ulan, danno

CC:
v8-dev

Base URL:
git@github.com:v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Do not call reinterpret_cast when converting from NULL. If NULL is a nullptr (such as on my FreeBSD system), it is not possible to use reinterpret_cast to convert it to another pointer. Plus, just using NULL directly achieves the same effect. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15705

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/heap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/stub-cache.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

7 years, 5 months ago (2013-07-17 08:46:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15705 (presubmit successful).

Expand Messages | Collapse Messages