runtime/vm/pages.cc - Issue 1938653002: JIT precompilated snapshots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/pages.cc

Issue 1938653002: JIT precompilated snapshots. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/pages.cc

diff --git a/runtime/vm/pages.cc b/runtime/vm/pages.cc

index 05e01fb50351c09b16deeaa91856945d8ae51dc4..64b1d5e91f7d342c85cc9622fba2cd1d72c9db40 100644

--- a/runtime/vm/pages.cc

+++ b/runtime/vm/pages.cc

@@ -211,7 +211,7 @@ HeapPage* PageSpace::AllocatePage(HeapPage::PageType type) {

} else {

// Should not allocate executable pages when running from a precompiled

// snapshot.

- ASSERT(!Dart::IsRunningPrecompiledCode());

+ ASSERT(Dart::snapshot_kind() != Snapshot::kAppNoJIT);

if (exec_pages_ == NULL) {

exec_pages_ = page;