chrome/browser/component_updater/sth_set_component_installer.h - Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/sth_set_component_installer.h

Issue 1937683002: Implement support in DefaultComponentInstaller for picking up bundled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments through #35 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/origin_trials_component_installer.cc ('k') | chrome/browser/component_updater/sth_set_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/sth_set_component_installer.h

diff --git a/chrome/browser/component_updater/sth_set_component_installer.h b/chrome/browser/component_updater/sth_set_component_installer.h

index ba3df76981b540226e88d04871f0717d976a220d..4223aa371d544d355d2d13685196b8e28d09f46f 100644

--- a/chrome/browser/component_updater/sth_set_component_installer.h

+++ b/chrome/browser/component_updater/sth_set_component_installer.h

@@ -57,7 +57,7 @@ class STHSetComponentInstallerTraits : public ComponentInstallerTraits {

void ComponentReady(const base::Version& version,

const base::FilePath& install_dir,

std::unique_ptr<base::DictionaryValue> manifest) override;

- base::FilePath GetBaseDirectory() const override;

+ base::FilePath GetRelativeInstallDir() const override;

void GetHash(std::vector<uint8_t>* hash) const override;

std::string GetName() const override;

std::string GetAp() const override;