Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 19369003: Turn on i18n support in V8. (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
danno, adamk
CC:
chromium-reviews
Visibility:
Public.

Description

Turn on i18n support in V8. The switch from the v8-i18n extension to the built-in support is done in blink. BUG=v8:2745 R=danno@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213418

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-16 13:17:56 UTC) #1
danno
lgtm
7 years, 5 months ago (2013-07-16 14:15:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/19369003/13001
7 years, 5 months ago (2013-07-24 09:14:35 UTC) #3
commit-bot: I haz the power
Change committed as 213418
7 years, 5 months ago (2013-07-24 12:34:34 UTC) #4
adamk
7 years, 5 months ago (2013-07-24 18:31:45 UTC) #5
Message was sent while issue was closed.
Note that I'm rolling this out in https://codereview.chromium.org/19476008/ due
to a crash in fast/workers/stress-js-execution.html:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

Powered by Google App Engine
This is Rietveld 408576698